Repository navigation
bip93: Require integer header thresholds - #11
Merged
Merged
Conversation
BenWestgate
added
gate: adversarial review
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
commented
Sep 25, 2026
BenWestgate
left a comment
BenWestgate
left a comment
Owner
Author
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
ACK 7d88913
- Closes the
2.0float hole;boolis still rejected first.
This was referenced Sep 25, 2026
Check the runtime threshold type before range membership so numerically equal floats cannot enter immutable BIP93 headers and fail later during symbol encoding. Security: strengthens the validated-artifact construction boundary without changing valid integer thresholds. Validation: focused public API and BIP93 tests; Ruff check and format; strict mypy.
BenWestgate
force-pushed
the
codex/v1-header-threshold-type
branch
from
September 28, 2026 00:07
7d88913 to
5051283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require
Header.thresholdto be a non-boolean integer before checking the BIP93range.
Why
Python numeric equality allowed
2.0through the range-membership check, leavinga float in an otherwise validated immutable header and failing later during
Bech32 symbol encoding. This adapts
Rob1Ham/python-codex32#11
onto the current target.
Validation